Skip to content

fix model primitive type case #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jannik-Hm merged 1 commit into from
Nov 20, 2025
Merged

fix model primitive type case #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type ModelReaderConf struct {
func GetModel(conf ModelReaderConf, desiredSize MeshTypes.Vector) (*MeshTypes.Mesh, error) {
var mesh *MeshTypes.Mesh

if conf.PrimitiveType == "undefined" && conf.File != nil && conf.Filename != nil && *conf.Filename != "" {
if conf.PrimitiveType == "Undefined" && conf.File != nil && conf.Filename != nil && *conf.Filename != "" {
filetype := filepath.Ext(*conf.Filename)
switch filetype {
case ".gltf", ".glb":
Expand All @@ -40,7 +40,7 @@ func GetModel(conf ModelReaderConf, desiredSize MeshTypes.Vector) (*MeshTypes.Me
default:
return nil, fmt.Errorf("unknown model type %s", filetype)
}
} else if conf.PrimitiveType != "undefined" && Primitives.Primitives[conf.PrimitiveType] != nil {
} else if conf.PrimitiveType != "Undefined" && Primitives.Primitives[conf.PrimitiveType] != nil {
tempMesh := Primitives.Primitives[conf.PrimitiveType].Copy()
mesh = &tempMesh
mesh.ScaleToDimensions(&desiredSize)
Expand Down