Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzers to detect incorrect usage of Content Managers for vanilla assets #922

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

SinZ163
Copy link
Contributor

@SinZ163 SinZ163 commented Nov 12, 2023

This Analyzer addition contains two new analyzers:

  1. AvoidContentManagerBadType
    • This will trigger when DataLoader can load the given Data asset, and the type is wrong. This is an error and will cause exceptions at runtime anyway
  2. PreferContentManagerDataLoader
    • This will trigger when DataLoader can load the given Data asset, regardless of type. This is Informative as its best practice, but the code will work anyway.

@SinZ163 SinZ163 changed the title Add analyzers to detect incorrect vanilla usage of Content Managers Add analyzers to detect incorrect usage of Content Managers for vanilla assets Nov 12, 2023
@Pathoschild Pathoschild deleted the branch Pathoschild:develop February 15, 2024 22:21
@Pathoschild Pathoschild reopened this Feb 15, 2024
@Pathoschild Pathoschild changed the base branch from alpha to develop February 15, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants