Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer texts in string.xml #329

Closed
Tracked by #328
taghizadlaura opened this issue Dec 17, 2024 · 0 comments · Fixed by #331
Closed
Tracked by #328

Timer texts in string.xml #329

taghizadlaura opened this issue Dec 17, 2024 · 0 comments · Fixed by #331
Assignees
@taghizadlaura
Labels
clean up Clean up of already written code

Comments

@taghizadlaura
Copy link
Contributor

taghizadlaura commented Dec 17, 2024 •
edited
Loading

Description:

This is a subtask from #328 . Refactor the TimerScreen by moving all the relevant strings into strings.xml to improve maintainability and localization support.

Done:

  • Added string resources for TimerScreen, including title, start text, useful tip, and button labels (START, RESET, STOP).
  • Refactored TimerScreen to use the newly defined string resources.
  • Updated TimerScreenTest to verify that the correct string resources are being used.
@taghizadlaura taghizadlaura mentioned this issue Dec 17, 2024
Open
4 tasks
@taghizadlaura taghizadlaura self-assigned this Dec 17, 2024
@taghizadlaura taghizadlaura added the clean up Clean up of already written code label Dec 17, 2024
@taghizadlaura taghizadlaura changed the title Timer texts in string.xml Timer texts in string.xml Dec 17, 2024
@taghizadlaura taghizadlaura mentioned this issue Dec 17, 2024
Merged
@taghizadlaura taghizadlaura linked a pull request Dec 17, 2024 that will close this issue
Fix/timer/extract strings #331
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taghizadlaura taghizadlaura

Labels
clean up Clean up of already written code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/timer/extract strings PeriodPals/periodpals
1 participant
@taghizadlaura