Fix/timer/extract strings #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add string resources for TimerScreen including title, start text, useful tip, and button labels (START, RESET, STOP). - Adapt TimerScreen to use the new string resources.
taghizadlaura
changed the title
…re being used. Also refactor `displayed_text_start` into `timer_displayed_text_start` for better consistency.
lazarinibruno
approved these changes
Dec 18, 2024
Harrish92
approved these changes
Dec 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timer texts in
string.xmlDescription
This PR introduces string resources for the TimerScreen to improve the readability and maintainability of the app. It closes issue #329 (and part of #328). The strings include a title, instructional text, useful tips, and labels for buttons (START, RESET, STOP). This update also adapts the TimerScreen to use the newly added string resources.
Changes
TimerScreen, including the title, instructions, useful tips, and button labels (START, RESET, STOP).strings.xml.Files
Added
Modified
TimerScreen.kt(updated to use string resources fromstrings.xml)TimerScreenTest.kt(updated the existing tests)res/values/strings.xml(new strings added)Removed
Dependencies Added
Testing
The TimerScreen has been updated to ensure the correct string resources are being used.