Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit screen texts to Figma in string.xml or other #328

Open
4 tasks done
taghizadlaura opened this issue Dec 17, 2024 · 0 comments
Open
4 tasks done

Fit screen texts to Figma in string.xml or other #328

taghizadlaura opened this issue Dec 17, 2024 · 0 comments
Assignees
Labels
clean up Clean up of already written code

Comments

@taghizadlaura
Copy link
Contributor

taghizadlaura commented Dec 17, 2024

Description

The task focuses on refactoring the Sign In and Sign Up screens by moving all relevant texts, including placeholders, error messages, and button labels, into the strings.xml file. This aligns with the guidelines provided in the individual grade of M2. The task also involves adding text resources for Profile, Settings, Alert, and Chat features to ensure consistency across the app and improve localization support.

NOTE: The task focuses only on text refactoring in the strings.xml file. UI-related color adjustments will be handled in a separate task.

Done

Specific, measurable criteria to confirm the task is complete:

  • Functional Requirements: All texts on the Sign In and Sign Up screens, including placeholders, error messages, and button labels, should be moved to strings.xml. This also applies to Profile, Settings, Alert, and Chat screens.
  • Quality Standards: The text resources in strings.xml should be well-organized, follow naming conventions, and be easily understandable for localization.
  • Testing Requirements: Ensure that all screens are using the correct string resources, and that there are no hardcoded strings in the UI. Update unit and UI tests to verify this.

Preconditions

  • Existing UI for Sign In, Sign Up, Profile, Settings, Alert, and Chat screens.
  • Existing layout files with placeholders, labels, and error messages.
  • App follows a consistent theming structure, with UI components relying on the strings.xml for text rendering.

Steps to Completion

Points to Consider / Known Risks

  • Localization: Consideration for different languages and the impact of longer or shorter text strings.
  • Backward Compatibility: Ensure no existing features are broken due to this refactoring, particularly if the strings are deeply integrated into various UI components.
  • Testing Complexity: Extensive testing across the Sign In, Sign Up, Profile, Settings, Alert, and Chat screens will be necessary to ensure consistency and correctness of the changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Clean up of already written code
Projects
None yet
Development

No branches or pull requests

1 participant