Split point_types.hpp part into field_traits.(h|hpp)
#6375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move `(H|h)as_` traits from `point_types.hpp` into `field_traits.(h|hpp)` * Add `field_traits.h` include where field traits are used * Change a MSVC compiler warning reset via `#pragma warning((push|pop))` * Add `field_traits.h` include in `point_types.h` for backward compatibility Signed-off-by: Ramir Sultanov <sumir0@proton.me>
sumir0
changed the title
point_types.hpp part into field_traits.(h|hpp)point_types.hpp part into field_traits.(h|hpp)
Contributor
Author
|
Also may fix #5040 |
Contributor
Author
|
Based on #6367 |
Signed-off-by: Ramir Sultanov <sumir0@proton.me>
Signed-off-by: Ramir Sultanov <sumir0@proton.me>
Contributor
Author
|
I will try to build manually with Edit: Compilation finished successfully. |
sumir0
changed the title
point_types.hpp part into field_traits.(h|hpp)point_types.hpp part into field_traits.(h|hpp)
mvieth
reviewed
Dec 1, 2025
* Remove unnecessary `pcl/point_types.h` includes in some files * Add missing `pcl/point_types.h` includes in some files Signed-off-by: Ramir Sultanov <sumir0@proton.me>
* Change license description in `pcl/field_traits.(h|hpp)` Signed-off-by: Ramir Sultanov <sumir0@proton.me>
* Add missing `pcl/point_types.h` includes in `examples` Signed-off-by: Ramir Sultanov <sumir0@proton.me>
sumir0
changed the title
point_types.hpp part into field_traits.(h|hpp)point_types.hpp part into field_traits.(h|hpp)
* Add missing `pcl/point_types.h` includes in some files Signed-off-by: Ramir Sultanov <sumir0@proton.me>
Add missing `cstring` include in `common/include/pcl/common/impl/copy_point.hpp` Signed-off-by: Ramir Sultanov <sumir0@proton.me>
Contributor
Author
|
For a moment I thought I was going under some water here... Phew, it was close! Excuse me for informality. As the pipelines are passing it seems that we are good to go (or maybe not, because there are still some files for which it would be nice to add missing includes, but they can be added in other PRs, possibly) |
sumir0
changed the title
point_types.hpp part into field_traits.(h|hpp)point_types.hpp part into field_traits.(h|hpp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(H|h)as_traits frompoint_types.hppintofield_traits.(h|hpp)field_traits.hinclude where field traits are used#pragma warning((push|pop))field_traits.hinclude inpoint_types.hfor backward compatibilitypcl/point_types.hincludes in some filespcl/point_types.hincludes in some filescstringinclude inpcl/common/impl/copy_point.hpp