-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 2023 launch aesthetic tweaks #30
Conversation
@joshuagraber this is about ready to be reviewed, then applied to |
Nice @josh-chamberlain! I also have some minor misc cleanup (docs, comments, etc.) I'd like to get in, are you good if I push those to this branch once you're ready? |
@joshuagraber sure thing! I will still rewrite the commits if you don't get to it but feel free to make any changes you'd like. it pairs with the |
* fix: quick search form validation (#28) * update(QuickSearchForm): one field must be filled * test: add and update misc tests: Add - Vuelidate utils, Update - components: Form, Footer, Header, Nav * chore: bump version -> 2.0.5 (#29) * feat: initial ci/cd pipeline (#31) * test: update misc snapshots * ci: add test:ci script for quiet console output * build(files): update package.json * ci: add github actions Pull: runs build, lint, test, Release: runs above, then releases via semantic-release * docs: rename doc dir -> docs * chore(deps): add semantic release * refactor(workflows): miscellaneous edits * chore(deps): use node v20.6.1 * chore(directories): move cli to top level * chore(deps): add commitizen add commitizen, add conventional changelog adapter * fix(components): update miscellaneous styles per stylelint * chore(deps): add and configure husky and lint-staged * docs(contributing): move -> docs/ * chore(husky): add pre-push hook to run tests * refactor(tools): move tools src -> ./ * feat(config): export tailwind config with library * fix(lint): update linting config * chore: misc updates to package scripts * docs(readme,contributing): update miscellaneous docs document new scripts and build process * fix(build): use quiet test script in pre-push hook * fix(ci): update workflow actions use checkout@v4, fetch depth 0 for lint script * fix(ci): add fetch-depth: 0 to release action (#32) * fix(ci): misc updates and fixes (#33) update release action to use new token, use npx, align files field in package.json * ci(release): update token used * Revert "ci(release): update token used" This reverts commit a64d5a5. * chore: revert "ci(release): update token used" This reverts commit a64d5a5. * ci(release): attempt to use base GITHUB_TOKEN to raise PR (#34) * ci: update release config * style: update lint errors * ci: update config * docs(contributing): update example commits * ci(release): remove plugins updating git from semantic-release config * docs(changelog): point to github release log * chore: cleanup package.json --------- Co-authored-by: Joshua Graber <68428039+joshuagraber@users.noreply.github.com> Co-authored-by: Joshua Graber <joshua.d.graber@gmail.com>
Add status badges,
Bring coverage to 100%
b5a2044
to
10a8593
Compare
Morning, @josh-chamberlain. I've added what I was hoping to here, re-wrote commit messages, and approved. Should be g2g. (FYI, I force-pushed after the rebasing to amend the commit messages, so probably need to force-pull or ort merge on your end, if you're pulling this to test locally.) |
@joshuagraber nice, LGTM! |
🎉 This PR is included in version 2.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #36
should be followed by Police-Data-Accessibility-Project/data-sources-app#130