feat: add the git-hook:install command #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2024
GeorgeCadwallader
suggested changes
Apr 11, 2024
Summary: Create the `git-hook:install` command to install git hooks. This is the same as the last one. We have added some extra environment variables to the hooks to allow for future expansion. This will mainly give us the ability to prompt the user to update the hooks if they are out of date. Test Plan: Tests have been written, I have also tested this manually by running the command in a sapling and git repo. Ref: #76
GeorgeCadwallader
approved these changes
Apr 17, 2024
|
All looks good to me, just got some tests failing that need sorting 👍 |
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add the git-hook:install command
Summary:
Create the
git-hook:installcommand to install git hooks. This is the same asthe last one. We have added some extra environment variables to the hooks to
allow for future expansion. This will mainly give us the ability to prompt the
user to update the hooks if they are out of date.
Test Plan:
Tests have been written, I have also tested this manually by running the
command in a sapling and git repo.
Ref: #76
Stack created with Sapling. Best reviewed with ReviewStack.