fix(git-hooks): non interactive hooks #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2024
GeorgeCadwallader
approved these changes
May 27, 2024
Summary: Right now in our git hooks we are using `git rev-parse --show-toplevel` to get the root of the repository. This is not working within a sapling repo. This implements the root command so we can use that instead. It as a new `root` method to the `SourceControlProvider` interface. This will then be implemented by any provider we want to. Test Plan: No real way to test this other than running the command and checking the output. As long as the hooks commands will be working for us this will be fine for now.
Summary: When you are running hooks in a non interactive terminal, the hooks will fail as they are expecting user input. This change will allow the hooks to run in a non interactive terminal. It splits out the writer to not show progress when when running in a non interactive. You will now only get the output at the end of the process to see what has passed and filed. Test Plan: No tests for now, this is quite hard to test because we are not actually testing in a live terminal, everything is mocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(git-hooks): non interactive hooks
Summary:
When you are running hooks in a non interactive terminal, the hooks will fail
as they are expecting user input. This change will allow the hooks to run in a
non interactive terminal.
It splits out the writer to not show progress when when running in a non
interactive. You will now only get the output at the end of the process to see
what has passed and filed.
Test Plan:
No tests for now, this is quite hard to test because we are not actually
testing in a live terminal, everything is mocked.
Stack created with Sapling. Best reviewed with ReviewStack.