Matplotlib #230
Matplotlib #230
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 33cf10c |
|
I've addressed @michaelavs and @brian-rose 's comments to #170 where @dopplershift was also a reviewer |
jukent
requested review from
dopplershift,
anissa111,
mgrover1,
brian-rose and
michaelavs
and removed request for
a team,
dopplershift and
anissa111
| @@ -0,0 +1,744 @@ | |||
| { | |||
There was a problem hiding this comment.
The verbs here should be consistent - consider changing "Learn" in the first two bullets to "Learning"
Reply via ReviewNB
There was a problem hiding this comment.
I changed all these bullets to match the section headings.
There was a problem hiding this comment.
Looks great - thanks for making those changes! Just a couple of minor comments, also for some reason the Pandas notebook was changed too, with the small change being that your branch uses master instead main for the branch... not sure why that change is tracked here...
There was a problem hiding this comment.
I resolved several comment threads, and opened a few new ones over at ReviewNB. I'm not sure why my comments are showing up here on GitHub. I had the same problem in #170. But my comments should be visible on ReviewNB.
This PR kept failing because of a link in the pandas notebook being broken. I should have made that change in a separate PR, but I just quickly did it here. |
|
@brian-rose Thanks for catching that, it should be updated now. |
Co-authored-by: Brian Rose <brose@albany.edu>
Co-authored-by: Brian Rose <brose@albany.edu>
Co-authored-by: Brian Rose <brose@albany.edu>
Co-authored-by: Brian Rose <brose@albany.edu>
Co-authored-by: Brian Rose <brose@albany.edu>
Attempt to resolve #170 from @mgrover1