-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More matplotlib #233
More matplotlib #233
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: bc1df23 |
I wouldn't be surprised if the link to |
Requesting review from all reviewers of #167 |
@@ -0,0 +1,2314 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you show an example where you set normalize=False? Working with values that do not add up to 100?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one minor comment I left on ReviewNB
…undations into more-matplotlib
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes @jukent ! Good to go!!
Attempt to get comments from @anissa111 #167 merged into foundations.