Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More matplotlib #233

Merged
merged 18 commits into from
Feb 22, 2022
Merged

More matplotlib #233

merged 18 commits into from
Feb 22, 2022

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Feb 22, 2022

Attempt to get comments from @anissa111 #167 merged into foundations.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: bc1df23
✅ Deployment Preview URL: https://6215590e11ed6b25ade53955--pythia-foundations.netlify.app

@jukent
Copy link
Contributor Author

jukent commented Feb 22, 2022

I wouldn't be surprised if the link to additional-topics2 was broken, since that is in #230

@jukent jukent marked this pull request as ready for review February 22, 2022 20:56
@jukent jukent requested a review from a team as a code owner February 22, 2022 20:56
@jukent jukent requested review from brian-rose, michaelavs, anissa111, a team, clyne and mgrover1 and removed request for a team February 22, 2022 20:56
@jukent
Copy link
Contributor Author

jukent commented Feb 22, 2022

Requesting review from all reviewers of #167

@@ -0,0 +1,2314 @@
{
Copy link
Contributor

@mgrover1 mgrover1 Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show an example where you set normalize=False? Working with values that do not add up to 100?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one minor comment I left on ReviewNB

@jukent jukent requested a review from mgrover1 February 22, 2022 21:36
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes @jukent ! Good to go!!

@jukent jukent merged commit a63d364 into ProjectPythia:main Feb 22, 2022
@jukent jukent deleted the more-matplotlib branch February 22, 2022 22:14
@jukent jukent added the content Content related issue label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants