Adding matplotlib tutorial content #167
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 274cb98 |
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I respectfully disagree? As a style point, we should use numpy when we're referring specifically to Python code (e.g. import statements), but when referring to the name of the package in English text, we should follow the NumPy docs and our own Foundations chapter and write it as "NumPy"
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
In most of the content, we typically refrain from including comments in the cell - could you cover this within the markdown above?
Reply via ReviewNB
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
Can you add the following few sections at the end?
* Summary
* What's Next
* Resources and References
Reply via ReviewNB
|
Overall @anissa111 , this looks great! Thanks for putting this together. Just a few minor formatting/template matching suggestions! |
|
Thanks @mgrover1, I'll get to those! |
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
If you remove comments from the code blocks above, then do the same here for consistency!
Reply via ReviewNB
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
First, this is cool! I actually didn't know about this Matplotlib functionality, and I love the "explode" argument.
Second, can you add some explanation for the last argument autopct?
Reply via ReviewNB
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
Similar to my comment above about "NumPy", we should write the name of the package as "Matplotlib" (with capitalization) where it appears in the text.
Reply via ReviewNB
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
Possible to explain in one or two sentences what is rc , or what this command does?
Reply via ReviewNB
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #10. plt.pie(sizes, labels=labels, explode=explode, colors=colors, autopct='%1.1f%%');
What does autopct do?
Reply via ReviewNB
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. def animate(i):
Can you say more about how i changes with each invocation? Presumably i is an integer that is incremented by 1 and starts from 0...Perhaps it is more complicated than that?
Reply via ReviewNB
| @@ -0,0 +1,2297 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. anim.save('animate.gif', writer='pillow');
gifs are perhaps not the best format for animations (though they are portable). Are there other, more modern codecs supported by matplotlib.animation that might be a better choice for the example, or perhaps just a mention?
Reply via ReviewNB
…undations into more-matplotlib
for more information, see https://pre-commit.ci
|
Closing from #233 |
Addresses #102
This notebook adds content from the first matplotlib tutorial and the advanced plotting with geocat-viz tutorial.