Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some connectors and ingestors added #11

Closed
wants to merge 24 commits into from
Closed

some connectors and ingestors added #11

wants to merge 24 commits into from

Conversation

the-non-expert
Copy link
Contributor

Added a AWS connector class and a local storage connector class
Added a pdf ingestor with proper test files as well.

@saraswatpuneet
Copy link
Contributor

@the-non-expert i like it, but lets further modify them once @debanjanamex sets the connector_base connector_factory and connector_resolver

@debanjanamex you can take clues from functions exposed in this PR for aws etc. and think about local directory connector to define the starting base classes

saraswatpuneet
saraswatpuneet approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job guys please keep adding more tests think of types and error handling but loving the momentum

@Ansh5461 Ansh5461 deleted the ayush branch January 2, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-non-expert @saraswatpuneet @Ansh5461