Finish client GUI #621
Merged
Finish client GUI #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional fixes: - Move SubtitlePositioner (not only GUI logic) - Remove invalid PacketReportProvider mapping (by gradle task) - Append `website` to wordlist
IotaBread
added
t: new
|
Can you enable actions on your fork of the repository so that I can download the generated diff? |
- Well, fastutil is still down, but at least it is *less* broken...
Should be enabled now. Since I pushed a new commit as well, it performs a fresh run of the workflows, which I couldn't get it to do with the old commit. |
supersaiyansubtlety
requested changes
Jul 25, 2024
mappings/net/minecraft/client/gui/screen/TelemetryDataScreen.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/screen/realms/RealmsBackupScreen.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/screen/realms/RealmsMainScreen.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/widget/list/EntryListWidget.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/widget/list/world/WorldEntryListWidget.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/widget/list/world/WorldEntryListWidget.mapping
Outdated
Show resolved
Hide resolved
ix0rai
reviewed
Jul 25, 2024
mappings/net/minecraft/client/gui/screen/realms/RealmsMainScreen.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/screen/realms/RealmsMainScreen.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/screen/world/CreateWorldScreen.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/widget/CheckboxWidget.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/widget/CheckboxWidget.mapping
Outdated
Show resolved
Hide resolved
mappings/net/minecraft/client/gui/widget/list/EntryListWidget.mapping
Outdated
Show resolved
Hide resolved
|
Applied some of your suggestions, let me know what you think! |
770grappenmaker
commented
Jul 25, 2024
mappings/net/minecraft/client/gui/WorldGenerationProgressTracker.mapping
Show resolved
Hide resolved
OroArmor
requested changes
Jul 25, 2024
mappings/net/minecraft/client/gui/screen/realms/RealmsPlayerScreen.mapping
Show resolved
Hide resolved
ix0rai
approved these changes
Jul 25, 2024
|
Did not mean to rerequest @ix0rai for review (screw you github for moving the UI unexpectedly) |
OroArmor
approved these changes
Jul 25, 2024
supersaiyansubtlety
approved these changes
Jul 26, 2024
|
When would this be eligible for merge? |
supersaiyansubtlety
added
final-comment-period
|
whoops, I was supposed to start fcp when I approved, mb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title. My first QM contribution, please be gentle!
Additional fixes:
SubtitlePositioner(not only GUI logic)PacketReportProvidermapping (by gradle task)websiteto wordlist