Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Hardpoint UI Fixes (#416)" #618

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Revert "Hardpoint UI Fixes (#416)" #618

merged 1 commit into from
Apr 19, 2023

Conversation

GeckoEidechse
Copy link
Member

This reverts commit 28d444c from #416

As it causes crash as explained in #416 (review)

@GeckoEidechse
Revert "Hardpoint UI Fixes (#416)"
a395e43 
This reverts commit 28d444c.

As it causes crash as explained in #416 (review)
@GeckoEidechse
Copy link
Member Author

@x3Karma as an FYI

pg9182
pg9182 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@pg9182 pg9182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't crash with the revert. Tested the commit and revert on main and 1.12.

RoyalBlue1
RoyalBlue1 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@RoyalBlue1 RoyalBlue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it is a revert I only approve because of the requirements. Did not look at it at all

@GeckoEidechse GeckoEidechse merged commit 04b1b0b into main Apr 19, 2023
@GeckoEidechse GeckoEidechse deleted the revert-hardpoint_fix branch April 19, 2023 22:47
GeckoEidechse added a commit that referenced this pull request Apr 19, 2023
@GeckoEidechse
Revert "Hardpoint UI Fixes (#416)" (#618)
79ebd18 
This reverts commit 28d444c.

As it causes crash as explained in #416 (review)
GeckoEidechse pushed a commit that referenced this pull request Apr 22, 2023
@x3Karma
Revert "Revert 'Hardpoint UI Fixes (#416)' (#618)" (#619)
64b666d 
* fixed not showing Auto-Titans death in killfeed

* revert indents

* revert indents again

* bug fix

* Hardpoint Fixes

* "fixed" spacing

for like one line the rest of the file is kinda oof tho but not related to my pr

* 69 spacing

* SetPlayerNetInt is placed inside a player entity check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyalBlue1 RoyalBlue1 RoyalBlue1 approved these changes

@pg9182 pg9182 pg9182 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeckoEidechse @RoyalBlue1 @pg9182