Skip to content

Add online task R3BOnlineSyncCheck #191

Add online task R3BOnlineSyncCheck

Add online task R3BOnlineSyncCheck #191

Triggered via pull request October 31, 2023 21:03
Status Failure
Total duration 3m 3s
Artifacts

static_analysis.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error, 11 warnings, and 1 notice
clang-tidy
Process completed with exit code 1.
clang-tidy
Unexpected input(s) 'repo', valid inputs are ['r3b-dev-key', 'cache-name']
clang-tidy: analysis/online/R3BOnlineSyncCheck.h#L15
macro 'R3BOnlineSyncCheck_H' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
clang-tidy: analysis/online/R3BOnlineSyncCheck.h#L29
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor,hicpp-explicit-conversions]
clang-tidy: analysis/online/R3BOnlineSyncCheck.h#L30
annotate this function with 'override' or (rarely) 'final' [cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override]
clang-tidy: analysis/online/R3BOnlineSyncCheck.h#L31
annotate this function with 'override' or (rarely) 'final' [cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override]
clang-tidy: analysis/online/R3BOnlineSyncCheck.h#L32
annotate this function with 'override' or (rarely) 'final' [cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override]
clang-tidy: analysis/online/R3BOnlineSyncCheck.h#L33
annotate this function with 'override' or (rarely) 'final' [cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override]
clang-tidy: r3bdata/synccheckData/R3BSyncCheckData.h#L39
function 'GetFoot' should be marked [[nodiscard]] [modernize-use-nodiscard]
clang-tidy: r3bdata/synccheckData/R3BSyncCheckData.h#L53
member variable 'fFoot' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes,misc-non-private-member-variables-in-classes]
clang-tidy: r3bsource/sync_check/ext_h101_sync_check.h#L96
16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
clang-tidy: analysis/online/R3BOnlineSyncCheck.cxx#L96
assigning newly created 'gsl::owner<>' to non-owner 'TCanvas *' [cppcoreguidelines-owning-memory]
clang-tidy
Clang-tidy generates 20 warnings and 0 errors! Please fix them before being merged.