Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify prez:members declaration; add prez:FocusNode class to focus nodes #245

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Simplify prez:members declaration; add prez:FocusNode class to focus nodes #245

merged 2 commits into from
Jul 24, 2024

Conversation

recalcitrantsupplant
Copy link
Collaborator

@recalcitrantsupplant recalcitrantsupplant commented Jul 23, 2024 •
edited
Loading

  1. Remove use of blank nodes when specifying prez members
  2. Add prez:FocusNode declaration for object and listing results

Previous output:

exm:CatalogOne a dcat:Catalog ;
    prez:identifier "exm:CatalogOne" ;
    prez:label "Catalog One" ;
    prez:link "/catalogs/exm:CatalogOne" ;
    prez:members [ 
        prez:link "/catalogs/exm:CatalogOne/collections" .
    ]

New output after code changes:

exm:CatalogOne a dcat:Catalog ;
    prez:identifier "exm:CatalogOne" ;
    prez:label "Catalog One" ;
    prez:link "/catalogs/exm:CatalogOne" ;
    prez:members "/catalogs/exm:CatalogOne/collections" ;
    prez:type prez:FocusNode .

@recalcitrantsupplant
1. Remove use of blank nodes when specifying prez members. 2. Add pre…
5cf9d60 
…z:FocusNode declaration for object and listing results,
@recalcitrantsupplant recalcitrantsupplant mentioned this pull request Jul 23, 2024
Merged
lalewis1
lalewis1 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can't see any issues. Thanks

@lalewis1 lalewis1 merged commit ea539b1 into main Jul 24, 2024
1 check passed
@recalcitrantsupplant recalcitrantsupplant deleted the david/members-flattened-and-focus-node-decl branch August 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalewis1 lalewis1 lalewis1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@recalcitrantsupplant @lalewis1