Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

David/prez identifier homepage mediatypes #246

Merged
merged 11 commits into from
Jul 24, 2024
Merged

David/prez identifier homepage mediatypes #246

merged 11 commits into from
Jul 24, 2024

Conversation

recalcitrantsupplant
Copy link
Collaborator

  1. Process mediatype requests on homepage route ("/"). The homepage rendering does not use the same object/listing pattern/renderer that the rest of Prez does and was previously hardcoded to only return text/turtle.
  2. For prez identifiers, used in links, change from:
    (uri, DCTERMS.identifier, Literal(curie_for_uri, datatype=PREZ.identifier))
    to:
    (uri, PREZ.identifier, Literal(curie_for_uri))
    This simplifies frontend processing.

@recalcitrantsupplant
Add triples for the identifier and label of link parent components. A…
f280186 
…dd bugfix to prevent creation of links for top concepts/narrowers endpoints (which were generating incorrectly - and are not necessarily required.)
@recalcitrantsupplant recalcitrantsupplant mentioned this pull request Jul 23, 2024
Merged
recalcitrantsupplant and others added 2 commits July 24, 2024 09:15
@recalcitrantsupplant
Change rdf:type -> prez:type
281b16f
@lalewis1
Merge pull request #245 from RDFLib/david/members-flattened-and-focus…
ea539b1 
…-node-decl

Simplify prez:members declaration; add prez:FocusNode class to focus nodes
lalewis1
lalewis1 requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now.

prez/routers/management.py Outdated Show resolved Hide resolved
@lalewis1
Merge pull request #247 from RDFLib/david/bugfix-and-add-breadcrumbs-…
0849ac8 
…identifiers

Triples for parent link components + Bugfix to remove links for top concepts / narrowers endpoints
@lalewis1
Copy link
Collaborator

I'm happy to approve this and implement my suggestions later if you think it's a good idea.
You PR was fine. the suggestions would just make it more compliant with the connegp spec.

@recalcitrantsupplant
1. Change dcterms:identifier with prez:identifier datatype to prez:id…
38a973b 
…entifier datatype. 2. Expand accepted mediatypes on homepage
@recalcitrantsupplant
Add missing import
0e56730
@recalcitrantsupplant
use connegp for homepage and utilise return from graph function to ha…
eba8411 
…ndle annotated mediatypes.
@recalcitrantsupplant
Merge remote-tracking branch 'origin/david/prez-identifier-homepage-m…
76c26ec 
…ediatypes' into david/prez-identifier-homepage-mediatypes

# Conflicts:
#	prez/routers/management.py
#	prez/services/link_generation.py
lalewis1
lalewis1 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep looks good. speedy implementation!

@lalewis1 lalewis1 merged commit 77e6bcc into main Jul 24, 2024
1 check passed
@recalcitrantsupplant recalcitrantsupplant deleted the david/prez-identifier-homepage-mediatypes branch August 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalewis1 lalewis1 lalewis1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@recalcitrantsupplant @lalewis1