Baseline Power Prediction as Input for Shadow MPCs #43

lwaer · 2026-01-07T15:33:34Z

No description provided.

FelixStege

Hey, thanks for the work! I added some comments. Fell free to ask if anything is unclear!

.gitignore

agentlib_flexquant/data_structures/mpcs.py

agentlib_flexquant/generate_flex_agents.py

agentlib_flexquant/utils/parsing.py

examples/SimpleBuilding/sim_building.csv

examples/SimpleBuilding/mpc_and_sim/fmu_config_linux.json_temp

tests/snapshots/test_SimpleBuilding/test_simplebuilding/SimpleBuilding_neg_flex_summary.json

lwaer · 2026-01-13T16:44:37Z

I reviewed my implementations to be more dynamic. Now, custom_inputs can be defined in the flex_config.shadow_mpc_config_generator_data.

…t-for-shadow-mpcs

lwaer · 2026-01-14T13:08:05Z

We should check for the order, in which the MPCs run. Is it necessary to implement callbacks for the Shadow-MPCs to wait for the Baseline-MPC?

FelixStege · 2026-01-14T14:01:17Z

We should check for the order, in which the MPCs run. Is it necessary to implement callbacks for the Shadow-MPCs to wait for the Baseline-MPC?

This is already implemented, as the shadow MPCs wait for the full control trajectory of the Baseline. This is needed, since the controls of the shadow MPCs are constrained to the controls of the Baseline during market time

agentlib_flexquant/data_structures/flexquant.py

agentlib_flexquant/data_structures/mpcs.py

agentlib_flexquant/generate_flex_agents.py

lwaer · 2026-01-14T17:24:56Z

"custom_inputs": [
                    {"name": "P_el_base", "alias": "_P_el_base", "value": 0},

When initializing the baseline trajectory with value=0, everything runs smoothly. However, an initialization should in theory not be necessary for this variable, as the alias points on the baseline variable after the baseline runs. ],

…ower-prediction-as-input-for-shadow-mpcs

Copilot

Pull request overview

This pull request refactors the MPC configuration system to support custom inputs (like baseline power predictions) for Shadow MPCs. The main change replaces the weights attribute with a more flexible system using config_parameters_appendix and config_inputs_appendix lists.

Changes:

Refactored PFMPCData and NFMPCData to remove the weights attribute and use config_parameters_appendix and config_inputs_appendix with model validators that add default framework parameters
Added custom_inputs field to ShadowMPCConfigGeneratorConfig to support additional inputs for Shadow MPCs
Updated generate_flex_agents.py to use the new parameter/input appendix system
Added example FMU configuration file for SimpleBuilding

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
`agentlib_flexquant/data_structures/mpcs.py`	Removed `weights` attribute from `BaseMPCData`, `PFMPCData`, and `NFMPCData`; added model validators to automatically include default framework parameters and inputs
`agentlib_flexquant/data_structures/flexquant.py`	Added `custom_inputs` field and updated `assign_weights_to_flex` validator to assign weights and custom inputs to Shadow MPCs
`agentlib_flexquant/generate_flex_agents.py`	Removed code that handled weights separately; updated to use `config_parameters_appendix` and `config_inputs_appendix` throughout
`agentlib_flexquant/utils/parsing.py`	Added loop to append custom inputs from `config_inputs_appendix` when modifying Shadow MPC config classes
`examples/SimpleBuilding/mpc_and_sim/fmu_config_linux.json_temp`	New example configuration file for FMU-based simulation
`.gitignore`	Added `.vscode/` and `flexquant.egg-info/` to ignored patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

agentlib_flexquant/data_structures/flexquant.py

examples/SimpleBuilding/mpc_and_sim/fmu_config_linux.json_temp

agentlib_flexquant/data_structures/mpcs.py

agentlib_flexquant/data_structures/flexquant.py

agentlib_flexquant/utils/parsing.py

agentlib_flexquant/data_structures/mpcs.py

agentlib_flexquant/utils/parsing.py

agentlib_flexquant/data_structures/mpcs.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Allows appending custom parameters to the shadow MPC configurations. Now it extends existing `config_parameters_appendix` and `config_inputs_appendix` instead of overwriting them. This change ensures that default/pre-existing parameters are preserved when adding custom parameters.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

agentlib_flexquant/data_structures/flexquant.py

agentlib_flexquant/data_structures/mpcs.py

agentlib_flexquant/utils/parsing.py

agentlib_flexquant/data_structures/flexquant.py

agentlib_flexquant/data_structures/mpcs.py

agentlib_flexquant/utils/parsing.py

agentlib_flexquant/data_structures/flexquant.py

Refactors MPC data validation to ensure default parameters and inputs are included in the respective appendix lists. It introduces a helper function to simplify the process of adding missing default variables based on their names. This ensures that critical framework parameters are always present in the MPC configurations. The previous implementation in ShadowMPCConfigGeneratorConfig was redundant and has been simplified. Relates to #42

Ensures MPC variables are correctly initialized when loaded from dictionaries. Adds an example FMU configuration and associated simulation result file to showcase the interaction between MPC and FMU simulations within the framework. Adds FMU config to .gitignore. Swaps the position of `flex_event_duration` and `market_time` in the tests to ensure the correct parameter order. Related to #42

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

agentlib_flexquant/data_structures/mpcs.py

examples/SimpleBuilding/mpc_and_sim/fmu_config.json_temp

agentlib_flexquant/generate_flex_agents.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

agentlib_flexquant/data_structures/mpcs.py

agentlib_flexquant/generate_flex_agents.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

implemented feature

b4fbef4

lwaer requested a review from FelixStege January 7, 2026 15:33

lwaer linked an issue Jan 7, 2026 that may be closed by this pull request

Feature: Baseline Power Prediction as Input for Shadow MPCs #42

Open

lwaer self-assigned this Jan 7, 2026

LWaerderERC added 2 commits January 7, 2026 16:46

added to gitignore

ef12b00

update pytest snapshots

d49c1f6

FelixStege requested changes Jan 9, 2026

View reviewed changes

FelixStege marked this pull request as draft January 9, 2026 15:44

lwaer changed the title ~~implemented feature~~ Baseline Power Prediction as Input for Shadow MPCs Jan 13, 2026

add custom_inputs dynamically

17e6529

LWaerderERC and others added 3 commits January 14, 2026 13:43

finalized custom inputs for shadow mpcs

3024555

update snapshots

52ad934

Merge branch 'main' into 42-feature-baseline-power-prediction-as-inpu…

57b5c72

…t-for-shadow-mpcs

lwaer marked this pull request as ready for review January 14, 2026 13:06

lwaer requested a review from FelixStege January 14, 2026 14:02

FelixStege requested changes Jan 14, 2026

View reviewed changes

debugged the model validator

60bae97

FelixStege requested changes Jan 14, 2026

View reviewed changes

agentlib_flexquant/data_structures/mpcs.py Outdated Show resolved Hide resolved

agentlib_flexquant/generate_flex_agents.py Outdated Show resolved Hide resolved

agentlib_flexquant/generate_flex_agents.py Outdated Show resolved Hide resolved

lwaer mentioned this pull request Jan 19, 2026

Change callback structure MPCs #49

Merged

lwaer closed this Jan 19, 2026

lwaer reopened this Jan 19, 2026

LWaerderERC added 2 commits January 19, 2026 13:20

Merge remote-tracking branch 'origin/main' into 42-feature-baseline-p…

ae7f3e9

…ower-prediction-as-input-for-shadow-mpcs

review parameters and inputs appendix

f06f49e

lwaer requested a review from Copilot January 20, 2026 09:27

Copilot started reviewing on behalf of lwaer January 20, 2026 09:27 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

lwaer and others added 4 commits January 20, 2026 11:15

Update agentlib_flexquant/data_structures/mpcs.py

92ccc51

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

reduce redundancy

fde2cfa

debug config

1484349

lwaer requested a review from Copilot January 20, 2026 11:02

Copilot started reviewing on behalf of lwaer January 20, 2026 11:02 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

LWaerderERC added 3 commits January 20, 2026 14:29

delete file

c5f9026

lwaer requested a review from Copilot January 20, 2026 14:05

Copilot started reviewing on behalf of lwaer January 20, 2026 14:05 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

lwaer and others added 4 commits January 20, 2026 15:12

Update agentlib_flexquant/data_structures/mpcs.py

631676d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update agentlib_flexquant/data_structures/mpcs.py

ba5ed90

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update agentlib_flexquant/generate_flex_agents.py

9e52d57

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update examples/SimpleBuilding/mpc_and_sim/fmu_config.json_temp

c83ffdf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

lwaer requested a review from Copilot January 20, 2026 14:14

Copilot started reviewing on behalf of lwaer January 20, 2026 14:15 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

lwaer and others added 3 commits January 20, 2026 15:24

Update agentlib_flexquant/generate_flex_agents.py

452221d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update agentlib_flexquant/data_structures/mpcs.py

a918077

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update agentlib_flexquant/data_structures/mpcs.py

d708930

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

lwaer requested a review from FelixStege January 20, 2026 14:32

LWaerderERC added 5 commits January 20, 2026 17:18

change the order of the parameter appendix

b6982a5

add callback tracking of custom inputs

ce4287c

delete unwanted files

41e4717

update gitignore

deaa2ac

update snapshots

61f7d6d

lwaer mentioned this pull request Jan 20, 2026

clean-up variable check in shadow MPC cost function #54

Open

Baseline Power Prediction as Input for Shadow MPCs #43

Are you sure you want to change the base?

Baseline Power Prediction as Input for Shadow MPCs #43

Uh oh!

Conversation

lwaer commented Jan 7, 2026

Uh oh!

FelixStege left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lwaer commented Jan 13, 2026

Uh oh!

lwaer commented Jan 14, 2026

Uh oh!

FelixStege commented Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lwaer commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

lwaer commented Jan 14, 2026 •

edited

Loading