Change callback structure MPCs #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwaer
reviewed
Jan 19, 2026
Collaborator
There was a problem hiding this comment.
Do I understand correctly, that, by default, all baseline inputs and states are added as inputs to the shadow MPCs? In that case, the pull request #43 is outdated, right?
Contributor
Author
There was a problem hiding this comment.
No, since the Baseline power is an output. These are not added as ehre it is only about guaranteeing the same initial state for the optimization (outputs are nor iportant for that). So that issue is still relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just sending the
full_controls, the Baseline no sends its full knowledge (states, inputs, controls) to ensure, that the shadows work with exactly the same information. The shadows wait for every variable before starting theirdo_step