Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for AWS session tokens #31

Merged
merged 1 commit into from
Jan 16, 2024
Merged

added support for AWS session tokens #31

merged 1 commit into from
Jan 16, 2024

Conversation

Kevinwochan
Copy link
Contributor

  • allows using short term credentials from AWS STS

aws4 will discard the sessionToken when the parameter is falsey (null, undefined, etc)

@Kevinwochan
Copy link
Contributor Author

#28

@IbrahimCSAE IbrahimCSAE self-requested a review January 16, 2024 13:03
IbrahimCSAE
IbrahimCSAE approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IbrahimCSAE IbrahimCSAE merged commit 6042afc into RadicalImaging:master Jan 16, 2024
1 check passed
@JeffersonCurveBeam JeffersonCurveBeam mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbrahimCSAE IbrahimCSAE IbrahimCSAE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kevinwochan @IbrahimCSAE