Refactor/station manager calculations#215
Merged
brunohcfaria merged 3 commits intodevelopmentfrom Sep 3, 2025
Merged
Conversation
brunohcfaria
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering the same number of stations, the methods changed performance went from:
To:
Considering that the number of calls above are the same for a SINGLE SNAPSHOT, and that the dimensions were exactly the same as in a mss dc simulation, the gains are really good.
This change, together with the change in #214 took a simulation file from 35 seconds per drop to 8 seconds per drop (as expected of an approx. saved time of 12 + 18).