Replace Oniguruma regex patterns with PCRE ones. NOT TESTED!!! #102
Conversation
NOT TESTED!!! Per Raku#99, Github's regex validator does not accept Oniguruma regexes. There's some escaping/filtering going on that makes the report hard to interpret but I'm pretty sure I figured it out. (I think it's just some `\\p{Alpha}`s that needed translating to `\\pL\\pM`, and a `"("` and `")"` pair of strings that needed escaping of the parens).
|
I think ultimately we should be moving away from the "atom" part in the name so I'd say nevermind the testing for now. However, as per CONTRIBUTING.md, the JSON files are only checked in for these external repos to use them; they aren't meant to be altered directly. |
|
Also, apparently I messed up big time: I uploaded the JSON files with nondeterministic key order. That's hell to revise. The code was already there to treat it with sorted keys... Anyway, now I did that, after checking all four JSON's that they haven't changed. @raiph If that's fine with you, I would just modify the corresponding .raku file, while switching the strings to an unquoted version (I didn't do that all at once because it seemed a lot of hassle but it might gradually evolve). This PR can be used as a reference because the same changes should be reflected in the JSON file. |
|
I did a PR showing what the current "architecture" is and we confirmed it contains the same practical content. Closing this PR now. |
NOT TESTED!!!
Per #99, Github's regex validator does not accept Oniguruma regexes. There's some escaping/filtering going on that makes the report hard to interpret but I'm pretty sure I figured it out. (I think it's just some
\\p{Alpha}s that needed translating to\\pL\\pM, and a"("and")"pair of strings that needed escaping of the parens).