[feat] Toggle Super_user privileges #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes - added tests for it - removes /debug pages from the dev feature flags
|
Please add test coverage instead how many test cases are getting passed and failed. |
Tejs1
approved these changes
Sep 14, 2024
Tejs1
approved these changes
Sep 14, 2024
Tejs1
approved these changes
Sep 14, 2024
Ayushsanjdev
approved these changes
Sep 15, 2024
- Adds toast as on both success as well failure - Adds test case covering the non-success reponse from serves
yesyash
approved these changes
Sep 18, 2024
Achintya-Chatterjee
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
13-09-2024Developer Name:
Shubham RajIssue Ticket Number:-
Description:
This PR remove page /debug from the feature flag, and makes the feature fully functional
Is Under Feature Flag
rather remove this page from the dev feature flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
development environment tested using with the staging data
on toggle roles super_user changes to false
Screencast.from.18-09-24.04.41.47.AM.IST.webm
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
test coverage for toggle button's functionality
test coverage for removing the page from the feature flag
