This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
Fix SMS Segment Ordering Issue in smsdb_put #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition check in the smsdb_put function now ensures all segments are received before processing. This fixes the issue where the segments were received out of order and the message was not being reassembled correctly.
RoEdAl
approved these changes
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #11 (comment)
The condition check in the smsdb_put function now ensures all segments are received before processing. （when order == parts, (e.g. the quectel receive the msg parts in the order of 1, 3, 2, after received the third msg, the
res > 0 && order == partsconditions will be satisfied, however part 2 of the msg still not received.This commit may fixes the issue where the segments were received out of order and the message was not being reassembled correctly.