Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the nodes, libraries and configurations. #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Install the nodes, libraries and configurations. #36

wants to merge 2 commits into from

Conversation

AlexisTM
Copy link

@AlexisTM AlexisTM commented Jan 2, 2020

This allows using ros_rslidar in an installed catkin environment.

Copy link

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the install rules of nodelet_rslidar.xml and nodelets.xml in the packages rslidar_driver and rslidar_pointcloud

Copy link

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AlexReimann
Copy link

merge?

@saikishor
Copy link

yes. I think now it looks good!

@AlexReimann
Copy link

@Tony-HIT

@HaoQChen
Copy link
Contributor

HaoQChen commented Feb 7, 2021

Hi Alex, We are not going to maintain this project, please use our new driver rslidar_sdk

the new driver supports ROS, ROS2, and you can even use it in Windows without ROS or ROS2.

Sorry to take so long to reply you, Tony always be busy here and there

@saikishor
Copy link

Hello @HaoQChen,

If you are not maintaining this repo anymore, please do mention in a Readme the same and please put a link to your new driver, so please can redirect to the new package, else, it is really hard to find out.

I hope you understand

@HaoQChen
Copy link
Contributor

HaoQChen commented Feb 9, 2021

and

copy that, I have add it to README.

Wish you a happy Chinese New Year

@saikishor
Copy link

Awesome. That's what I am talking about. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants