Skip to content

Conversation

@Ranga-Prasath-22
Copy link

#168)

This test suite verifies the integration and functionality of the ChatGoogleGenerativeAI model, including initialization, invocation, error handling, and support for model variants.

Purpose

  • Clear purpose of this PR

Proposed Changes

What does this PR add, remove or fix?

Issues

  • Links to relevant issues

Testing

  • How was it tested, what were the results?

…obotecAI#168)

This test suite verifies the integration and functionality of the ChatGoogleGenerativeAI model, including initialization, invocation, error handling, and support for model variants.
@maciejmajek
Copy link
Member

Thank you for the contribution! I appreciate the effort you put into adding tests for Google GenAI integration.

A few points to note:

  • The PR does not add the langchain-google-genai dependency, so these tests won’t run out of the box.
  • The added tests are heavily mocked. While they might make sense for testing the LangChain package itself, they don’t really test RAI, which uses LLMs in a less conventional way. Fully mocked tests like these don’t provide much value here.
  • For RAI, testing LLM integrations works better through manual testing. Before configuring the model in config.toml, the initialization module should be updated to support the new LLM vendor. Then you can manually test by running the demos to verify everything works as expected.

Just so you know, our current contributor @sachinkum0009 is also working on Google GenAI integration. You could coordinate to pick up the work together or test the capabilities separately.

Thanks again!

@sachinkum0009
Copy link
Contributor

Thanks for the PR and for the heads-up! I actually haven't started working on this specific issue yet. If you are already mid-way through, feel free to take the lead. Otherwise, I’m happy to discuss how we can divide the tasks so we aren't duplicating effort. What do you think?

@Ranga-Prasath-22
Copy link
Author

@maciejmajek Thank you for the feedback! I'll update the PR to include the langchain-google-genai dependency and add support for the Google LLM vendor in the initialization module. I'll also work on making the tests more meaningful for RAI.

@sachinkum0009 Thanks! I'm already partway through these changes, so I'll go ahead and finish the core setup. We can definitely coordinate on further features once the basic integration is merged!

- Add langchain-google-genai dependency to pyproject.toml
- Add GoogleConfig dataclass and vendor support in model_initialization.py
- Add [google] section to config template with gemini-3-flash/gemini-3-pro
- Add unit tests for RAI framework integration logic

Closes RobotecAI#168
Syncing patch-1 with main (latest fixes and upstream changes)
@Ranga-Prasath-22
Copy link
Author

@maciejmajek @sachinkum0009 Thank you for the guidance! I've updated the PR with the following changes:

  • Added langchain-google-genai as a dependency in pyproject.toml.
  • Updated model_initialization.py to support the Google LLM vendor.
  • Added the [google] configuration section to config_initialization.py and the config.toml template.
  • Added comprehensive unit tests for the initialization logic and integrated the Google GenAI model.

Please let me know if there's anything else I should address. This is my first open-source contribution, so I appreciate your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants