Lucas S. files for the April tags environment #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasJSch
changed the title
Ready for review |
Was this already addressed? Also is this PR "[WIP]"? |
Yes, it has. Forgot to delete it. Also forgot to delete the "[WIP]". |
LucasJSch
changed the title
eborghi10
requested changes
Oct 16, 2019
Still have to address the pose definition issue in the SDF file of the four static april tags.
eborghi10
requested changes
Oct 18, 2019
eborghi10
requested changes
Oct 20, 2019
To do: decrease the size of the environment for using smaller image files from camera.
To do: upload apriltag_ros as as internal package in create_autonomy.
|
Also, fix the merge conflicts please. |
eborghi10
requested changes
Oct 22, 2019
| <xacro:macro name="april_tag" params="name_prefix base_link *origin"> | ||
|
|
||
| <link name="${name_prefix}_april_tag_link"> | ||
| <visual> |
There was a problem hiding this comment.
I just realized about this. Is the visual tag mandatory? Since you only want to apply a texture, do you need to create this visual block?
There was a problem hiding this comment.
If I delete this, the Apriltag doesn't appear. This xacro corresponds to the Apriltag of the robot.
How can a texture be applied if there is no visual object to apply it to?
| @@ -2,5 +2,5 @@ free_thresh: 0.196 | |||
| image: empty.pgm | |||
| negate: 0 | |||
| occupied_thresh: 0.65 | |||
| origin: [-6.8999999999999915, -5.8999999999999915, 0.0] | |||
| origin: [0.0, 0.0, 0.0] | |||
stevendes
approved these changes
Oct 24, 2019
eborghi10
force-pushed
the
kinetic-devel
branch
3 times, most recently
from
23e75d6
to
05fa7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added files for creating an environment for testing the April tags package of ROS.
Environment
Tags detected by the apriltag_ros package
Frames detected by the apriltag_ros package