Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 17, 2025

  • Analyze the workflow file and understand the issue
  • Fix the release job condition to accept tags with or without 'v' prefix
  • Fix the workflow trigger pattern to be consistent with release job condition
  • Verify the workflow syntax is correct
  • Test that the workflow would work for both tag formats
  • Run code review to verify no issues remain
  • Run security check
Original prompt

This section details on the original issue you should resolve

<issue_title>Release</issue_title>
<issue_description>Create release job is always skipped</issue_description>

<agent_instructions>fix the workflow and the create release job</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: RusEu <11183790+RusEu@users.noreply.github.com>
@RusEu RusEu marked this pull request as ready for review December 17, 2025 23:42
Copilot AI review requested due to automatic review settings December 17, 2025 23:42
Co-authored-by: RusEu <11183790+RusEu@users.noreply.github.com>
@RusEu RusEu merged commit 893239c into master Dec 17, 2025
2 checks passed
Copilot AI requested a review from RusEu December 17, 2025 23:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue where the release job in the GitHub Actions workflow was always being skipped. The fix modifies both the workflow trigger pattern and the release job condition to be more permissive, allowing any tag (not just those with a 'v' prefix) to trigger releases.

Key Changes:

  • Updated tag trigger pattern from 'v*' to '*' to accept all tags
  • Modified release job condition from startsWith(github.ref, 'refs/tags/v') to startsWith(github.ref, 'refs/tags/') for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- master
tags:
- 'v*'
- '*'
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard pattern '' will trigger the workflow for any tag, including non-release tags (e.g., experimental tags, build tags, etc.). This could cause unintended releases to be created. Consider using a more specific pattern like 'v' or '[0-9]+.' to match only semantic version tags. If you need to support tags both with and without the 'v' prefix, consider using 'v[0-9]+.' for tags with prefix, or establish a clear tagging convention for releases.

Suggested change
- '*'
- 'v*'

Copilot uses AI. Check for mistakes.
needs: build
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/v')
if: startsWith(github.ref, 'refs/tags/')
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change makes the condition consistent with the trigger pattern and fixes the skipped job issue, it also means ANY tag will trigger a release. This could lead to accidental releases from non-version tags. Consider being more specific, such as checking if the tag matches a version pattern using a regex or conditional expression. For example, you could add an additional condition to verify the tag format matches semantic versioning expectations.

Suggested change
if: startsWith(github.ref, 'refs/tags/')
if: startsWith(github.ref, 'refs/tags/') && github.ref_name matches '^v?[0-9]+\.[0-9]+\.[0-9]+$'

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release

2 participants