Skip to content

[WIP] Fix skipped create release job in workflow #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RusEu merged 3 commits into from
Dec 17, 2025
Merged

[WIP] Fix skipped create release job in workflow #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a43a52
Initial plan
Copilot Dec 17, 2025
dd6beb3
Fix release job condition to accept all tag formats
Copilot Dec 17, 2025
db1cdea
Fix workflow trigger to accept all tags, not just v* tags
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-and-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- main
- master
tags:
- 'v*'
- '*'
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard pattern '' will trigger the workflow for any tag, including non-release tags (e.g., experimental tags, build tags, etc.). This could cause unintended releases to be created. Consider using a more specific pattern like 'v' or '[0-9]+.' to match only semantic version tags. If you need to support tags both with and without the 'v' prefix, consider using 'v[0-9]+.' for tags with prefix, or establish a clear tagging convention for releases.

Suggested change
- '*'
- 'v*'

Copilot uses AI. Check for mistakes.
pull_request:
branches:
- main
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
name: Create Release
needs: build
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/v')
if: startsWith(github.ref, 'refs/tags/')
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change makes the condition consistent with the trigger pattern and fixes the skipped job issue, it also means ANY tag will trigger a release. This could lead to accidental releases from non-version tags. Consider being more specific, such as checking if the tag matches a version pattern using a regex or conditional expression. For example, you could add an additional condition to verify the tag format matches semantic versioning expectations.

Suggested change
if: startsWith(github.ref, 'refs/tags/')
if: startsWith(github.ref, 'refs/tags/') && github.ref_name matches '^v?[0-9]+\.[0-9]+\.[0-9]+$'

Copilot uses AI. Check for mistakes.
permissions:
contents: write

Expand Down