-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 메인페이지 퍼블리싱 #116
[FEAT] 메인페이지 퍼블리싱 #116
Conversation
🪷 Storybook 확인 🪷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
화면 이쁘네용!! 현재 캐러셀 터치 로직에서 드래그 시 화면이 같이 밀리는 현상이 있어서 touch-action: none
을 추가해서 해당 동작을 막는 로직을 추가해주시면 더욱 좋을 것 같습니다!! 짱짱 !!
@@ -0,0 +1,26 @@ | |||
import { style } from '@vanilla-extract/css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 스타일에서 flex스타일이 반복적으로 사용중이라서
import { style } from '@vanilla-extract/css';
const flexCenterColumn = style({
display: 'flex',
flexDirection: 'column',
alignItems: 'center',
justifyContent: 'center',
});
export const homeWrapper = flexCenterColumn;
export const curationCarouselStyle = style([
flexCenterColumn,
{
gap: '0.8rem',
marginTop: '5.4rem',
},
]);
export const popularCarouselStyle = style([
flexCenterColumn,
{
gap: '0.8rem',
margin: '5.4rem 0 28rem 0',
},
]);
이런식으로 정의해서 반복되는 스타일을 빼면 더욱 좋을 것 같아요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
성희님이 말한 것 처럼 화면 같이 움직이는 현상만 확인해주시면 될 것 같아요 고생하셨슴다~~ 뷰 예쁘네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
커서!! 포인터!! 커서!! 포인터!!
반영헤줘잉
통일성 가지자요
이미 반영되어있어잉 |
🛰️ 관련 이슈
🧑💻 작업 내용
🗯️ PR 포인트
🚀 알게된 점
📖 참고 자료 (선택)
📸 스크린샷 (선택)
2025-01-20.8.31.56.mov