-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 메인페이지 퍼블리싱 #116
Merged
Merged
[FEAT] 메인페이지 퍼블리싱 #116
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import LookCard from '@components/card/lookCard/LookCard'; | ||
import MapCard from '@components/card/mapCard/MapCard'; | ||
import CurationCarousel from '@components/carousel/curationCarousel/CurationCarousel'; | ||
import CarouselIndex from '@components/carousel/popularCarousel/CarouselIndex'; | ||
import PopularCarousel from '@components/carousel/popularCarousel/PopularCarousel'; | ||
import DetailTitle from '@components/detailTitle/DetailTitle'; | ||
import Footer from '@components/footer/Footer'; | ||
import Header from '@components/header/Header'; | ||
|
||
import * as styles from './homePage.css'; | ||
|
||
const HomePage = () => { | ||
return ( | ||
<div className={styles.homeWrapper}> | ||
<Header /> | ||
<LookCard name="절로가" /> | ||
<MapCard /> | ||
<div className={styles.curationCarouselStyle}> | ||
<DetailTitle title="절로가 큐레이션" /> | ||
<CurationCarousel /> | ||
</div> | ||
<div className={styles.popularCarouselStyle}> | ||
<DetailTitle title="이번주 인기스테이" /> | ||
<PopularCarousel /> | ||
<CarouselIndex total={3} currentIndex={1} /> | ||
</div> | ||
<Footer /> | ||
</div> | ||
); | ||
}; | ||
|
||
export default HomePage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { style } from '@vanilla-extract/css'; | ||
|
||
const flexCenterColumn = style({ | ||
display: 'flex', | ||
flexDirection: 'column', | ||
alignItems: 'center', | ||
justifyContent: 'center', | ||
}); | ||
|
||
export const homeWrapper = flexCenterColumn; | ||
|
||
export const curationCarouselStyle = style([ | ||
flexCenterColumn, | ||
{ | ||
gap: '0.8rem', | ||
marginTop: '5.4rem', | ||
}, | ||
]); | ||
|
||
export const popularCarouselStyle = style([ | ||
flexCenterColumn, | ||
{ | ||
gap: '0.8rem', | ||
margin: '5.4rem 0 28rem 0', | ||
}, | ||
]); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import HomePage from '@pages/homePage/HomePage'; | ||
import type { Meta, StoryObj } from '@storybook/react'; | ||
|
||
const meta = { | ||
title: 'Page/HomePage', | ||
component: HomePage, | ||
parameters: { | ||
layout: 'centered', | ||
}, | ||
tags: ['autodocs'], | ||
} satisfies Meta<typeof HomePage>; | ||
|
||
export default meta; | ||
|
||
type Story = StoryObj<typeof meta>; | ||
|
||
export const Default: Story = {}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 스타일에서 flex스타일이 반복적으로 사용중이라서
이런식으로 정의해서 반복되는 스타일을 빼면 더욱 좋을 것 같아요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3c9128c 90fcf60 말씀해주신 부분들 반영했습니다 ~!