Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old helm-test k8s namespaces #290

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

pdostal
Copy link
Collaborator

@pdostal pdostal commented Aug 3, 2023

ocw/lib/k8s.py Outdated Show resolved Hide resolved
ocw/lib/k8s.py Outdated Show resolved Hide resolved
asmorodskyi
asmorodskyi previously approved these changes Aug 3, 2023
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdostal pdostal force-pushed the clean_helm_namespaces branch 15 times, most recently from cff8b4d to b748ab9 Compare August 5, 2023 07:39
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 98.07% and project coverage change: +0.48% 🎉

Comparison is base (bff2e16) 78.56% compared to head (b73e634) 79.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   78.56%   79.05%   +0.48%     
==========================================
  Files          21       21              
  Lines        1549     1585      +36     
==========================================
+ Hits         1217     1253      +36     
  Misses        332      332              
Files Changed Coverage Δ
ocw/lib/gke.py 58.33% <92.85%> (+7.35%) ⬆️
ocw/lib/aks.py 95.23% <100.00%> (+0.95%) ⬆️
ocw/lib/eks.py 85.61% <100.00%> (+0.99%) ⬆️
ocw/lib/k8s.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdostal pdostal force-pushed the clean_helm_namespaces branch 9 times, most recently from c5bc6ea to ffbbbc9 Compare August 6, 2023 15:22
@pdostal pdostal force-pushed the clean_helm_namespaces branch 2 times, most recently from d598a54 to e49208f Compare August 6, 2023 15:39
ocw/lib/k8s.py Outdated Show resolved Hide resolved
ocw/lib/k8s.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion. Otherwise LGTM.

ocw/lib/k8s.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardobranco777 ricardobranco777 merged commit cecc978 into SUSE:master Aug 7, 2023
10 checks passed
Copy link
Collaborator Author

@pdostal pdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants