Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes #304

Merged
merged 2 commits into from
Aug 31, 2023
Merged

More fixes #304

merged 2 commits into from
Aug 31, 2023

Conversation

ricardobranco777
Copy link
Collaborator

This PR:

  • Disables insecure=True in Openstack now that we install SUSE certificates.
  • Fix a couple of minor pylint issues.

ocw/lib/openstack.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6b39d20) 78.81% compared to head (01e991d) 78.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files          21       21           
  Lines        1614     1614           
=======================================
  Hits         1272     1272           
  Misses        342      342           
Files Changed Coverage Δ
ocw/lib/ec2.py 78.43% <0.00%> (ø)
ocw/lib/gce.py 89.86% <0.00%> (ø)
ocw/lib/openstack.py 77.10% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asmorodskyi
asmorodskyi previously approved these changes Aug 31, 2023
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asmorodskyi asmorodskyi merged commit 1759a6b into SUSE:master Aug 31, 2023
10 of 11 checks passed
@ricardobranco777 ricardobranco777 deleted the fixit branch August 31, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants