Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes #304

Merged
merged 2 commits into from
Aug 31, 2023
Merged

More fixes #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3097af
Fix no-else-continue / no-else-return
ricardobranco777 Aug 31, 2023
01e991d
Disable insecure=True in Openstack
ricardobranco777 Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ocw/lib/ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@
if exc.response['Error']['Code'] == 'InvalidParameterValue':
self.log_info(exc.response['Error'])
continue
else:
raise
raise

Check warning on line 184 in ocw/lib/ec2.py

View check run for this annotation

Codecov / codecov/patch

ocw/lib/ec2.py#L184 

Added line #L184 was not covered by tests
if self.dry_run:
self.log_info(f'Deletion of {subnet} skipped due to dry_run mode')
else:
Expand Down
3 changes: 1 addition & 2 deletions ocw/lib/gce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@
if GCE.get_error_reason(exc) == 'notFound':
self.log_dbg("list_zones: region {} not found", region)
return []
else:
raise exc
raise exc

Check warning on line 106 in ocw/lib/gce.py

View check run for this annotation

Codecov / codecov/patch

ocw/lib/gce.py#L106 

Added line #L106 was not covered by tests

def delete_instance(self, instance_id, zone) -> None:
self._delete_resource(
Expand Down
1 change: 0 additions & 1 deletion ocw/lib/openstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def client(self) -> None:
if self.__client is None:
self.__client = openstack.connect(
debug=bool(DEBUG),
insecure=True, # Trust the certificate
auth_url=self.get_data('auth_url'),
project_name=self.get_data('project_name'),
username=self.get_data('username'),
Expand Down
Loading