change condition value to svfvar in intracfgedge #1572
Merged
+40
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleisui
reviewed
Oct 12, 2024
| @@ -157,7 +157,7 @@ void ICFGBuilder::processFunBody(WorkList& worklist) | |||
| } | |||
| InstVec nextInsts; | |||
| LLVMUtil::getNextInsts(inst, nextInsts); | |||
| u32_t branchID = 0; | |||
| s64_t branchID = 0; | |||
There was a problem hiding this comment.
I thought this would be more consistent with the field branchCond being of type s64_t.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1572 +/- ##
=======================================
Coverage 62.86% 62.86%
=======================================
Files 244 244
Lines 25694 25698 +4
Branches 4514 4519 +5
=======================================
+ Hits 16152 16155 +3
- Misses 9542 9543 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.