Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnx-subgraph initial PR, add CMakeLists.txt #14630

Closed
wants to merge 1 commit into from

Conversation

chenyx113
Copy link
Contributor

initial PR of onnx-subgraph tool.
related issue of: #14534
historical draft PR:
#14613

historical comments: #14621 (comment)

please check with historical full changes PR, thank you

ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com

@chenyx113 chenyx113 marked this pull request as ready for review February 11, 2025 02:18
@seanshpark
Copy link
Contributor

from #14621 (comment)

I will check in my local that the build is OK according to your README file how to build.
If the build is success, I'll land that PR.
And prepare a Workflow to check following PR build is success or not.

please check cmake build with current ONE master + files in this PR
and remove lines that will drop errors while configure/build with this CMakeLists.txt
purpose is to let CI do the build check with your changes
so that someone including me don't have to do manual build checks.

@seanshpark
Copy link
Contributor

as an example, I like to prepare stuffs like this;

@chenyx113
Copy link
Contributor Author

from #14621 (comment)

I will check in my local that the build is OK according to your README file how to build.
If the build is success, I'll land that PR.
And prepare a Workflow to check following PR build is success or not.

please check cmake build with current ONE master + files in this PR and remove lines that will drop errors while configure/build with this CMakeLists.txt purpose is to let CI do the build check with your changes so that someone including me don't have to do manual build checks.

OK, I will preprare an empty CMakelists

as an example, I like to prepare stuffs like this;

OK, I understand your needs from the example, just empty CMKELISTS is needed to debug the CI. I will prepare, thanks for the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants