task(files): Add failed msg to upload failing

[Flemmli97]

What this PR does 📖

• Adds the error message to pending message if an error occurred during file upload
• Also show the error as a toast notification

Which issue(s) this PR fixes 🔨

• Resolve task(files): Show toast notification when user is sending file but limit is reached #1848

[github-actions]

UI Automated Test Results Summary for MacOS/Windows

534 tests   480 ✅  2h 58m 44s ⏱️
 45 suites   54 💤
  3 files      0 ❌

Results for commit 1254aad.

♻️ This comment has been updated with latest results.

[github-actions]

UI Automated Tests execution is complete! You can find the test results report here

[phillsatellite]

Sara and I both tried and had the same results

File limit was reached and we tried to then send a file in the chat but got no toast notification and message would not show as failed

We tried to send the same file on dev branch and on dev on the message bubble it will at least say failed

[stavares843]

same here 🔨

[Flemmli97]

fixed. but the toast msg will also have the same problem as #1877

[stavares843]

thanks 🔨

[stavares843]

is there a way to make the copy more user friendly?

can we remove where it says

Current length: 11461366070. Minimum Length: None, Maximum: Some(10737418240)

and add the MB's instead?

[Flemmli97]

is there a way to make the copy more user friendly?

can we remove where it says

Current length: 11461366070. Minimum Length: None, Maximum: Some(10737418240)

and add the MB's instead?

hmm idk about that. it currently simply prints the error provided by a failed download.
and that error msg is provided by warp.

we can of course simply print a simple error message with something along the line of:
"Error during download - "
but this also looses any other potential context

[stavares843]

we can just add a message saying "Error on upload, no space left on storage" and maybe we could add the same storage size we use on the files section

[Flemmli97]

we can just add a message saying "Error on upload, no space left on storage" and maybe we could add the same storage size we use on the files section

the thing is though that error might not be related to a full storage as its just a generic one. so always displaying it as "full storage" is misleading.
so we could only have "Error on upload"

[stavares843]

"Error on upload - lack of storage" works fine

[Flemmli97]

like i said what if that error is not caused by lack of storage?
e.g. the wifi went out?
there is no way to tell. we would need to have warp send the actual error struct instead of just passing in a string

[dariusc93]

like i said what if that error is not caused by lack of storage? e.g. the wifi went out? there is no way to tell. we would need to have warp send the actual error struct instead of just passing in a string

My PR already changes it to an Error, so once that is merged in, we can use that instead

[stavares843]

sounds good, thank you 🔨