Add citation.cff #159
Merged
Add citation.cff #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ SBML = "1.4.4" | |||
| SBMLToolkitTestSuite = "0.0.3" | |||
| SafeTestsets = "0.1" | |||
| Sundials = "4.14" | |||
| SymbolicUtils = "2" | |||
| SymbolicUtils = "1, 2" | |||
There was a problem hiding this comment.
why would we add back 1?
There was a problem hiding this comment.
I thought the less restrictive we are with our compats, the less likely developers who may depend on SBMLtk have compatibility issues. Also because of a compatibility requirement with the latest Catalyst release. Looks like the next release will no longer have a SymbolicUtils requirement, tho.
paulflang
commented
Jun 26, 2024
src/reactions.jl
Outdated
| @@ -163,7 +163,7 @@ Get rate constant of mass action kineticLaws | |||
| function get_massaction(kl::Num, reactants::Union{Vector{Num}, Nothing}, | |||
| stoich::Union{Vector{<:Real}, Nothing}) | |||
| function check_args(x::SymbolicUtils.BasicSymbolic{Real}) | |||
| check_args(Val(SymbolicUtils.istree(x)), x) | |||
| check_args(Val(SymbolicUtils.TermInterface.iscall(x)), x) | |||
There was a problem hiding this comment.
Also, do you know why this does not fix this, but instead causes failure in Downgrade.yaml? And why does Downgrade julia-actions/julia-runtest@v1, if it is already present in CI.yaml?
There was a problem hiding this comment.
There might be more in ModelingToolkit to handle.
ChrisRackauckas
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds citation information to readme. Updates tests so that they pass despite warnings.