Add citation.cff #159
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,7 +163,7 @@ Get rate constant of mass action kineticLaws | |
| function get_massaction(kl::Num, reactants::Union{Vector{Num}, Nothing}, | ||
| stoich::Union{Vector{<:Real}, Nothing}) | ||
| function check_args(x::SymbolicUtils.BasicSymbolic{Real}) | ||
| check_args(Val(SymbolicUtils.TermInterface.iscall(x)), x) | ||
|
There was a problem hiding this comment. Also, do you know why this does not fix this, but instead causes failure in Downgrade.yaml? And why does Downgrade There was a problem hiding this comment. There might be more in ModelingToolkit to handle. |
||
| end | ||
|
|
||
| function check_args(::Val{true}, x::SymbolicUtils.BasicSymbolic{Real}) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we add back 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the less restrictive we are with our compats, the less likely developers who may depend on SBMLtk have compatibility issues. Also because of a compatibility requirement with the latest Catalyst release. Looks like the next release will no longer have a SymbolicUtils requirement, tho.