Lazy median aggregator #6167
Merged
Lazy median aggregator #6167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6167 +/- ##
==========================================
- Coverage 89.85% 89.85% -0.01%
==========================================
Files 88 88
Lines 23384 23392 +8
Branches 4356 4357 +1
==========================================
+ Hits 21012 21019 +7
Misses 1646 1646
- Partials 726 727 +1 ☔ View full report in Codecov by Sentry. |
12 tasks
|
Ping @SciTools/peloton, this is looking for a reviewer |
ESadek-MO
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Thanks @fnattino!
All the code looks great, happy with this. I've rerun the tests, as there was an issue with readthedocs that we've since fixed, so assuming they pass, I'm happy with this.
The only thing to say is that we're now trying to ensure any new tests are written in pytest, using the _shared_utils file for all conveniences. That said, I believe this was put in place after you pushed this PR up, so the fault lies on me for my late review! If you fancy rewriting them in pytest, ideal, if not I'm happy to do so myself once this is merged in.
|
Thanks for the review @ESadek-MO ! No problem, I have now updated the test module to pytest. Please let me know whether there is anything else that should still be addressed here! |
9 tasks
pp-mo
added
the
benchmark_this
⏱️ Performance Benchmark Report: 869691fPerformance shiftsFull benchmark resultsGenerated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Adding the lazy implementation of the median aggregator, following the implementation discussed in #4039 .
It is true that the issue above suggests that there was not much interest for a lazy median, but it looked like it would need only little effort. And we thought it could still be useful to some ESMValTool users who might not be aware of the workaround of using the 50th percentile.
CC: @bouweandela