VUU-33 add context for layouts #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heswell
approved these changes
Sep 5, 2023
| @@ -81,7 +74,7 @@ export const ShellWithNewTheme = () => { | |||
| } | |||
| return menuDescriptors; | |||
| }, | |||
| async (action: MenuActionClosePopup) => { | |||
| (action: MenuActionClosePopup) => { | |||
There was a problem hiding this comment.
a MenuActionClose action has an options object. I made a change to add an attribute to that options object controlledComponetIdis the id of the component controlled by the tab from which the save layout menu was popped up. That gives you the id of the element we need to capture teh screen grab from. Will avoid that slightly fragile
getElementsByClassName("vuuShell-content")[0] to locate the element.
It can be passed as a prop straight into the SaveLayoutPanel
Base automatically changed from
feature/VUU-18-browse-layouts
to
feature/layout-management/layout-management-feature
September 6, 2023 10:15
…ttps://github.com/ScottLogic/finos-vuu into feature/VUU-33-Layout-Manager-Context
vferraro-scottlogic
merged commit f7ceec0
into
feature/layout-management/layout-management-feature
6 checks passed
cfisher-scottlogic
deleted the
feature/VUU-33-Layout-Manager-Context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.