forked from finos/vuu
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VUU-33 add context for layouts #35
Merged
vferraro-scottlogic
merged 6 commits into
feature/layout-management/layout-management-feature
from
feature/VUU-33-Layout-Manager-Context
Sep 6, 2023
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e3974e
VUU-33 add context for layouts
vferraro-scottlogic 872ee5c
VUU-33 update LayoutList example
vferraro-scottlogic d8d0d3a
VUU-33 add click handler on List items
vferraro-scottlogic 620d116
Merge branch 'feature/VUU-18-browse-layouts' of https://github.com/Sc…
vferraro-scottlogic 602b557
Merge branch 'feature/layout-management/layout-management-feature' of…
vferraro-scottlogic 82f0107
VUU-33 use componentId for screenshot
vferraro-scottlogic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export * from "./SaveLayoutPanel"; | ||
export * from "./LayoutList"; | ||
export * from "./layoutTypes"; | ||
export * from "./LayoutList" | ||
export * from "./layoutTypes" | ||
export * from "./useLayoutManager" |
21 changes: 14 additions & 7 deletions
21
vuu-ui/packages/vuu-shell/src/layout-management/layoutTypes.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,15 @@ | ||
import { LayoutJSON } from "@finos/vuu-layout"; | ||
|
||
export type LayoutMetadata = { | ||
name: string, | ||
group: string, | ||
screenshot: string, | ||
user: string, | ||
date: string, | ||
id: string | ||
} | ||
name: string; | ||
group: string; | ||
screenshot: string; | ||
user: string; | ||
date: string; | ||
id: string; | ||
}; | ||
|
||
export type Layout = { | ||
json: LayoutJSON; | ||
metadata: LayoutMetadata; | ||
}; |
50 changes: 50 additions & 0 deletions
50
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import React, { useState, useCallback, useContext, useEffect } from "react"; | ||
import { getLocalEntity, saveLocalEntity } from "@finos/vuu-filters"; | ||
import { LayoutJSON } from "@finos/vuu-layout"; | ||
import { getUniqueId } from "@finos/vuu-utils"; | ||
import { LayoutMetadata, Layout } from "./layoutTypes"; | ||
|
||
export const LayoutManagementContext = React.createContext<{ | ||
layouts: Layout[], | ||
saveLayout: (n: Omit<LayoutMetadata, "id">) => void | ||
}>({ layouts: [], saveLayout: () => { } }) | ||
|
||
export const LayoutManagementProvider = (props: { children: JSX.Element | JSX.Element[] }) => { | ||
|
||
const [layouts, setLayouts] = useState<Layout[]>([]) | ||
|
||
useEffect(() => { | ||
const layouts = getLocalEntity<Layout[]>("layouts") | ||
setLayouts(layouts || []) | ||
}, []) | ||
|
||
useEffect(() => { | ||
saveLocalEntity<Layout[]>("layouts", layouts) | ||
}, [layouts]) | ||
|
||
const saveLayout = useCallback((metadata: Omit<LayoutMetadata, "id">) => { | ||
const json = getLocalEntity<LayoutJSON>("api/vui") | ||
if (json) { | ||
setLayouts(prev => | ||
[ | ||
...prev, | ||
{ | ||
metadata: { | ||
...metadata, | ||
id: getUniqueId() | ||
}, | ||
json | ||
} | ||
] | ||
) | ||
} | ||
}, []) | ||
|
||
return ( | ||
<LayoutManagementContext.Provider value={{ layouts, saveLayout }} > | ||
{props.children} | ||
</LayoutManagementContext.Provider> | ||
) | ||
} | ||
|
||
export const useLayoutManager = () => useContext(LayoutManagementContext); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a MenuActionClose action has an options object. I made a change to add an attribute to that options object
controlledComponetId
is the id of the component controlled by the tab from which the save layout menu was popped up. That gives you the id of the element we need to capture teh screen grab from. Will avoid that slightly fragilegetElementsByClassName("vuuShell-content")[0] to locate the element.
It can be passed as a prop straight into the SaveLayoutPanel