Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #422 and resolves #418
This pull request introduces error panel handling improvements, adds support for high contrast mode in the options UI, and enhances user feedback in the options script. Key changes include managing error panels more effectively, adding accessibility features, and providing immediate feedback to users.
Error panel handling improvements:
errorPanelvariable to manage error panels consistently insrc/background.ts. Existing error panels are now closed before creating new ones in various scenarios, such as HTTP errors or context menu errors. [1] [2] [3] [4]Accessibility enhancements:
src/options/options.cssby using the@media (forced-colors: active)rule to adjust the appearance of sliders for better visibility.User feedback improvements:
optionsCheckfunction insrc/options/options.tsto display a browser alert with the saved preferences message, providing immediate feedback to users.