-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile 4 my hearts content #29
base: master
Are you sure you want to change the base?
Conversation
ds0nt
commented
Aug 6, 2015
RUN npm install -g grunt-cli coffee-script http-server | ||
|
||
ADD ./package.json /app/package.json | ||
RUN cd /app && npm install -q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're copying everything to the /app
folder some lines below, so I think you can avoid explicitly adding the package.json
there and simply run npm install -q
after you cd to the /app
folder (i.e.RUN cd /app && npm install -q && grunt build
).
In short, you can remove lines 11-12 and change lines 18-19 to:
ADD . /app
RUN cd /app && npm install -q && grunt build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copying the package.json first avoids time-consuming npm installs upon changes to the source-code. It will only install if package.json is affected.
I'm not sure if docker still works this way, but I beleive that if you were to simply copy it all at once, then it would npm install after changing even a config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copying the package.json first avoids time-consuming npm installs upon changes to the source-code. It will only install if package.json is affected.
I believe you're right. Let's leave it as is then.
This looks good. Thanks! Can you also update the README with instructions on how to build and run the docker image? A subsection under the Building header should be enough. |
Yikes, I really need to keep track of my github. Any tips on managing that? I'll do that for you. :) |
I guess you can enable email notifications for issues/pull requests you interact with. |