Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile 4 my hearts content #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dockerfile 4 my hearts content #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
FROM iojs:latest


#
# installation
#

RUN mkdir /app
RUN npm install -g grunt-cli coffee-script http-server

ADD ./package.json /app/package.json
RUN cd /app && npm install -q
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're copying everything to the /app folder some lines below, so I think you can avoid explicitly adding the package.json there and simply run npm install -q after you cd to the /app folder (i.e.RUN cd /app && npm install -q && grunt build).

In short, you can remove lines 11-12 and change lines 18-19 to:

ADD . /app
RUN cd /app && npm install -q && grunt build

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copying the package.json first avoids time-consuming npm installs upon changes to the source-code. It will only install if package.json is affected.

I'm not sure if docker still works this way, but I beleive that if you were to simply copy it all at once, then it would npm install after changing even a config file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copying the package.json first avoids time-consuming npm installs upon changes to the source-code. It will only install if package.json is affected.

I believe you're right. Let's leave it as is then.


#
# copy all
#

ADD . /app
RUN cd /app && grunt build


#
# Container Settings
#

EXPOSE 8080
WORKDIR /app
CMD http-server -p 8080