-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK cleanup, set up SDK in walletd #562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexfreska
commented
Mar 28, 2024
•
edited
Loading
edited
- Clean up SDK API, WebTransportClient parameters, tweaks
- Fix signTransaction and update to signTransactionV1
- Add basic SDK initialization to walletd
🦋 Changeset detectedLatest commit: d26a952 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
alexfreska
changed the title
sdk sign transaction tweaks, add to walletd
SDK cleanup and sign transaction tweaks, initialize in walletd
Mar 28, 2024
alexfreska
force-pushed
the
sdk_tweaks_add_to_walletd
branch
from
March 28, 2024 20:18
0b9b341
to
de6c631
Compare
alexfreska
force-pushed
the
sdk_tweaks_add_to_walletd
branch
from
March 29, 2024 21:06
de6c631
to
1ac1221
Compare
alexfreska
changed the title
SDK cleanup and sign transaction tweaks, initialize in walletd
SDK cleanup, set up SDK in walletd
Mar 29, 2024
alexfreska
force-pushed
the
sdk_tweaks_add_to_walletd
branch
from
March 30, 2024 11:47
1ac1221
to
d26a952
Compare
Merged
n8maninger
approved these changes
Apr 1, 2024
Merge activity
|
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.