-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: walletd rescan #566
feat: walletd rescan #566
Conversation
alexfreska
commented
Mar 30, 2024
•
edited
Loading
edited
- Address generation and addition dialogs now have an option to rescan from a specified height.
- There is now a dedicated rescan dialog that can be opened from the wallet list and wallet context menus.
- Rescan progress and status including errors is now shown in a sticky status bar.
🦋 Changeset detectedLatest commit: 6147c23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a51c9f4
to
f939602
Compare
I’m not sure we should enable this or maybe hide it behind an advanced flag. What do you think? |
@n8maninger The toggle defaults to OFF and in this state it does not show the index input or the warning below. Do you mean completely disable this feature by default via a daemon startup config value? Or do you mean just tucking it away a bit more than it is - maybe you have to expand the advanced section to even see the toggle? |
aee6084
to
2479eab
Compare
I don't know what would be best. My concern is that users will input a number in the index field without really understanding what it does and then be confused when their wallet doesn't show transactions. I meant tucking it away a bit more over a config flag or anything like that. It just needs to be very clear about the portion of blockchain that won't be scanned and the ramifications of that. |
f939602
to
9662ef8
Compare
9662ef8
to
6109fac
Compare
e17d92d
to
86a50ff
Compare
1fc2113
to
24e381e
Compare
24e381e
to
c395f2e
Compare
c395f2e
to
6cd613c
Compare
6cd613c
to
6147c23
Compare