Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operators reloading info #6780

Merged
merged 32 commits into from
Aug 30, 2024
Merged

Operators reloading info #6780

merged 32 commits into from
Aug 30, 2024

Conversation

Asleeepp
Copy link
Contributor

Description

Adds a config option to allow all players with the permission, to see whenever a player reloads a script, and the info that comes along with it, such as errors and/or warnings, etc.

Target Minecraft Versions: any
Requirements: none
Related Issues: #6736

sovdeeth
sovdeeth requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preliminary look-through

src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth June 11, 2024 18:03
sovdeeth
sovdeeth requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good but I would like to see an example of what it looks like.

src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Jun 28, 2024
@Asleeepp Asleeepp requested a review from sovdeeth June 28, 2024 17:15
@sovdeeth sovdeeth added the 2.9 Targeting a 2.9.X version release label Jun 29, 2024
@Moderocky Moderocky force-pushed the addition-operators-reloading-info branch from aa33f20 to 96edf65 Compare July 1, 2024 08:13
Moderocky
Moderocky previously requested changes Jul 1, 2024
View reviewed changes
src/main/resources/plugin.yml Outdated Show resolved Hide resolved
Asleeepp added 2 commits July 1, 2024 12:46
@Asleeepp
change
186f43d
@Asleeepp
Merge remote-tracking branch 'origin/addition-operators-reloading-inf…
c1ecc9e 
…o' into addition-operators-reloading-info

# Conflicts:
#	src/main/resources/plugin.yml
@Asleeepp Asleeepp requested a review from Moderocky July 1, 2024 15:48
APickledWalrus
APickledWalrus requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking in general it might be better to instead support multiple command senders in RedirectingLogHandler. It would avoid some of the more awkward changes.

src/main/resources/config.sk Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/log/RedirectingLogHandler.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/log/RedirectingLogHandler.java Outdated Show resolved Hide resolved
@APickledWalrus APickledWalrus removed the 2.9 Targeting a 2.9.X version release label Jul 1, 2024
@sovdeeth sovdeeth requested a review from APickledWalrus July 1, 2024 22:44
@Asleeepp Asleeepp requested a review from APickledWalrus July 12, 2024 17:42
@Asleeepp Asleeepp requested a review from APickledWalrus July 12, 2024 18:07
@APickledWalrus APickledWalrus requested a review from sovdeeth July 14, 2024 04:03
APickledWalrus
APickledWalrus approved these changes Jul 14, 2024
View reviewed changes
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
sovdeeth
sovdeeth requested changes Jul 14, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some slight changes

src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/log/RedirectingLogHandler.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/log/RedirectingLogHandler.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth July 14, 2024 20:26
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jul 18, 2024
sovdeeth
sovdeeth requested changes Aug 15, 2024
View reviewed changes
src/main/resources/config.sk Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth August 15, 2024 01:16
@sovdeeth sovdeeth added the 2.10 Targeting a 2.10.X version release label Aug 16, 2024
@Moderocky Moderocky merged commit c8cd975 into SkriptLang:dev/feature Aug 30, 2024
3 checks passed
@Moderocky Moderocky deleted the addition-operators-reloading-info branch August 30, 2024 13:54
@EquipableMC
Copy link
Contributor

EquipableMC commented Sep 21, 2024 •
edited
Loading

Issue with this, redirectingloghandler breaks stuff, I don't know why this was merged.

image

EquipableMC added a commit to EquipableMC/Skript that referenced this pull request Sep 21, 2024
@EquipableMC
Revert "Operators reloading info (SkriptLang#6780)"
4294e46 
This reverts commit c8cd975.
This was referenced Sep 21, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
2.10 Targeting a 2.10.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Asleeepp @EquipableMC @sovdeeth @Moderocky @APickledWalrus