-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds domestication syntax #6861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An expression with changers - A test for the expression
sovdeeth
requested changes
Jul 12, 2024
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
requested changes
Jul 18, 2024
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Jul 22, 2024
src/test/skript/tests/syntaxes/expressions/ExprDomestication.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprDomestication.sk
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Jul 24, 2024
Moderocky
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
- An expression with changers - A test for the expression
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Moderocky
force-pushed
the
domestication
branch
from
August 17, 2024 16:30
2707162
to
b6660a5
Compare
Moderocky
added
the
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
label
Aug 20, 2024
UnderscoreTud
requested changes
Sep 13, 2024
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDomestication.java
Outdated
Show resolved
Hide resolved
UnderscoreTud
approved these changes
Sep 14, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Pull request adding a new feature.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Target Minecraft Versions: any
Requirements: none
Related Issues: none